One of the things to improve code quality is doing proper reviews
– Require at least 2 reviews for a PR
– Assign reviewers automatically according to CODEOWNERS file
– Require status checks to pass before merging
CODEOWNERS could look as simple as:
As soon as you face any bug or issue, add a test on it to not miss it next time!
My new expectation is simply not empty table – expect_table_row_count_to_be_between from dbt_expectations package
– Require at least 2 reviews for a PR
– Assign reviewers automatically according to CODEOWNERS file
– Require status checks to pass before merging
CODEOWNERS could look as simple as:
* @owner1 @owner2 @owner3Another thing is testing expectations of your data
/models/flatten/ @owner1
/models/staging/ @owner2
/models/marts/ @owner3
As soon as you face any bug or issue, add a test on it to not miss it next time!
My new expectation is simply not empty table – expect_table_row_count_to_be_between from dbt_expectations package
tests:#codereview #codequality
- dbt_expectations.expect_table_row_count_to_be_between:
min_value: 100
GitHub Docs
About code owners - GitHub Docs
You can use a CODEOWNERS file to define individuals or teams that are responsible for code in a repository.