New issue to wemake-services/django-modern-rest by @sobolevn
Validate that we can't set `Set-Cookie` header and should use `cookies=` instead (#259)
When using
If so, we need to raise an error that
#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
Validate that we can't set `Set-Cookie` header and should use `cookies=` instead (#259)
When using
@validate and @modify we must check that no ResponseSpec.headers contain Set-Cookie header description / modification.If so, we need to raise an error that
cookies= parameter must be used instead.#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Validate that
We now support #234 cookies and their definition with
But, we don't have a validation / test for their correct usage, like we do for
Let's do it!
See validation:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L90-L104
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L443-L458
And test:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testendpoint/testmodifydecorator.py#L58-L69
This is a nice DX improvement.
#helpwanted #enhancement #goodfirst_issue
sent via relator
📝 Validate that
cookies= definition is correct (#273)We now support #234 cookies and their definition with
NewCookie and CookieSpec.But, we don't have a validation / test for their correct usage, like we do for
NewHeader / HeaderSpec.Let's do it!
See validation:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L90-L104
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L443-L458
And test:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testendpoint/testmodifydecorator.py#L58-L69
This is a nice DX improvement.
#helpwanted #enhancement #goodfirst_issue
sent via relator
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Test that we support new styled type aliases as request / return types (#275)
We have a special test case for different types that we support https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testvalidation/testtypevalidation.py#L48-L64
This test is missing a case like
Please, add it :)
Note, that
So, this needs to be added with a guard and probably
#goodfirstissue #enhancement #help_wanted
sent via relator
📝 Test that we support new styled type aliases as request / return types (#275)
We have a special test case for different types that we support https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testvalidation/testtypevalidation.py#L48-L64
This test is missing a case like
type MyInt = int
Please, add it :)
Note, that
type X is 3.12+ syntax, while we also support 3.11So, this needs to be added with a guard and probably
exec('type MyInt = int')#goodfirstissue #enhancement #help_wanted
sent via relator
😁1