🚀 New issue to wemake-services/wemake-python-styleguide by @sobolevn
📝 Allow
String like
We need to add it to https://github.com/wemake-services/wemake-python-styleguide/blob/7f4f7ae24309149aa03d36846a96fb4410b8022e/wemakepythonstyleguide/visitors/ast/complexity/overuses.py#L37
#feature #goodfirstissue #levelstarter #help_wanted
sent via relator
📝 Allow
/ in WPS226 (#3554)String like
'/' must not raise string overuse violation, because / is very common in url buildings / path building.We need to add it to https://github.com/wemake-services/wemake-python-styleguide/blob/7f4f7ae24309149aa03d36846a96fb4410b8022e/wemakepythonstyleguide/visitors/ast/complexity/overuses.py#L37
#feature #goodfirstissue #levelstarter #help_wanted
sent via relator
Никто не хочет законтрибутить в Pydantic?
Нужно добавить им в CI third-party прогон тестов для FastDepends
https://github.com/pydantic/pydantic/issues/12410
Вот в эту джобу, если что
Нужно добавить им в CI third-party прогон тестов для FastDepends
https://github.com/pydantic/pydantic/issues/12410
Вот в эту джобу, если что
GitHub
Add FastDepends to third-party test suite · Issue #12410 · pydantic/pydantic
FastDepends is a dependency injection library that serves as the underlying core for both the AG2 and FastStream frameworks. It provides Pydantic-based dependency resolution and type validation, ma...
👎7👍3🥴1
New issue to wemake-services/django-modern-rest by @sobolevn
Validate that we can't set `Set-Cookie` header and should use `cookies=` instead (#259)
When using
If so, we need to raise an error that
#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
Validate that we can't set `Set-Cookie` header and should use `cookies=` instead (#259)
When using
@validate and @modify we must check that no ResponseSpec.headers contain Set-Cookie header description / modification.If so, we need to raise an error that
cookies= parameter must be used instead.#django_modern_rest #help_wanted #enhancement #good_first_issue
sent via relator
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Validate that
We now support #234 cookies and their definition with
But, we don't have a validation / test for their correct usage, like we do for
Let's do it!
See validation:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L90-L104
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L443-L458
And test:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testendpoint/testmodifydecorator.py#L58-L69
This is a nice DX improvement.
#helpwanted #enhancement #goodfirst_issue
sent via relator
📝 Validate that
cookies= definition is correct (#273)We now support #234 cookies and their definition with
NewCookie and CookieSpec.But, we don't have a validation / test for their correct usage, like we do for
NewHeader / HeaderSpec.Let's do it!
See validation:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L90-L104
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/djangomodernrest/validation/endpoint_metadata.py#L443-L458
And test:
https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testendpoint/testmodifydecorator.py#L58-L69
This is a nice DX improvement.
#helpwanted #enhancement #goodfirst_issue
sent via relator
🚀 New issue to wemake-services/django-modern-rest by @sobolevn
📝 Test that we support new styled type aliases as request / return types (#275)
We have a special test case for different types that we support https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testvalidation/testtypevalidation.py#L48-L64
This test is missing a case like
Please, add it :)
Note, that
So, this needs to be added with a guard and probably
#goodfirstissue #enhancement #help_wanted
sent via relator
📝 Test that we support new styled type aliases as request / return types (#275)
We have a special test case for different types that we support https://github.com/wemake-services/django-modern-rest/blob/998715103c375edf4270cbf89cb68d5fad10365e/tests/testunit/testvalidation/testtypevalidation.py#L48-L64
This test is missing a case like
type MyInt = int
Please, add it :)
Note, that
type X is 3.12+ syntax, while we also support 3.11So, this needs to be added with a guard and probably
exec('type MyInt = int')#goodfirstissue #enhancement #help_wanted
sent via relator
😁1
🚀 New issue to ag2ai/faststream by @jsonvot
📝 Bug: The coexistence issue between URL and virtualhost (#2652)
Describe the bug
In version v0.5.33, the first method works properly, and the trailing slash (/) at the end of the URL cannot be omitted. However, in versions >=0.5.34, due to additional handling of virtualhost, only parameter-based formats like 2, 3, 4 and 5 are supported.
I believe method 5 is the most intuitive and should be handled correctly, but it is currently treated as an invalid format. Using this method will result in the following error:
🖼️Image
Environment
faststream[rabbit]>=0.5.34
#bug #good_first_issue #faststream #ag2ai
sent via relator
📝 Bug: The coexistence issue between URL and virtualhost (#2652)
Describe the bug
import asyncio
from faststream.rabbit import RabbitBroker
async def pub():
broker = RabbitBroker('amqp://guest:guest@localhost:5672/', virtualhost='/domestic-aed') # 1
#broker = RabbitBroker('amqp://guest:guest@localhost:5672', virtualhost='//domestic-aed') # 2
#broker = RabbitBroker('amqp://guest:guest@localhost:5672/', virtualhost='//domestic-aed') # 3
#broker = RabbitBroker('amqp://guest:guest@localhost:5672//domestic-aed') # 4
#broker = RabbitBroker('amqp://guest:guest@localhost:5672', virtualhost='/domestic-aed') # 5
async with broker:
await broker.publish(
"Hi!",
queue="test-queue",
exchange="test-exchange"
)
asyncio.run(pub())
In version v0.5.33, the first method works properly, and the trailing slash (/) at the end of the URL cannot be omitted. However, in versions >=0.5.34, due to additional handling of virtualhost, only parameter-based formats like 2, 3, 4 and 5 are supported.
I believe method 5 is the most intuitive and should be handled correctly, but it is currently treated as an invalid format. Using this method will result in the following error:
🖼️Image
Environment
faststream[rabbit]>=0.5.34
#bug #good_first_issue #faststream #ag2ai
sent via relator
👍1