soong json generation has improved a lot since pie. There are now saner functions to handle this. For reference, see this.
So, now our custom map's config.mk would looks something like this:
https://github.com/PotatoProject-next/vendor_potato/commit/6ca5af3c9647898ea60feab9c8711fa64333aa06
So, now our custom map's config.mk would looks something like this:
https://github.com/PotatoProject-next/vendor_potato/commit/6ca5af3c9647898ea60feab9c8711fa64333aa06
GitHub
soong_config: Switch to json_map calls · PotatoProject-next/vendor_potato@6ca5af3
Change-Id: I8b18665e40bb12c532c119e7a59b5848a1f9fe75
Signed-off-by: Kshitij Gupta
Signed-off-by: Kshitij Gupta
Oh also, if you come across a build error on libselinux, this should fix it:
https://github.com/PotatoProject-next/external_selinux/commit/b4177583030e8e6a16f8976c570562d319ce5a1b
Not sure if this is the right thing to do, but it at least gets things going.
https://github.com/PotatoProject-next/external_selinux/commit/b4177583030e8e6a16f8976c570562d319ce5a1b
Not sure if this is the right thing to do, but it at least gets things going.
GitHub
DNM: Fix libselinux inclusions · PotatoProject-next/external_selinux@b417758
Change-Id: Ic382c02cb0058e49b9f66118f6ad44c99cb2ae50
Signed-off-by: Kshitij Gupta <[email protected]>
Signed-off-by: Kshitij Gupta <[email protected]>
Most are probably aware, but yeah. Might as well add it here.
Set
add_lunch_combo is deprecated and lunch relies on a build var:Set
COMMON_LUNCH_CHOICES in your AndroidProducts.mk, instead.So, path_interposer will back up the current PATH data to a file in outdir. This is restored when soong is exiting. If you manage to kill soong during the build (or even hit Ctrl+c a bunch of times when it starts exiting from the initial interrupt), you'll be left with the PATH set for the build.
You may also be wondering as to why I'm using the prebuilt make while I'm running instructions against the original path. This is because
path.go will throw an error if I try to build specifying any path tools such as make.Oh also, I should mention, the soong kernel header generator also calls make. Fixed it up now, just need to clean-up and add my path override.
TARGET_OUT_INTERMEDIATE_LIBRARIES has now been removed.We are expected to use per-module intermediate dirs instead.
We'd need to move quite a few things from BoardConfig to product config makefiles
